Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up of test_sycl_queue_submit_local_accessor_arg.cpp #1990

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Clean up of test_sycl_queue_submit_local_accessor_arg.cpp #1990

merged 1 commit into from
Feb 12, 2025

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Clean-up of "libsyclinterface/tests/test_sycl_queue_submit_local_accessor_arg.cpp" file:

  1. Save filename of the test SPV into a variable and reuse it
  2. Add static_assert that SIZE is divisible by 10
  3. Replaced hard-coded expected value with one that depends on value of SIZE
  4. Fixed typos in the source code to generate SPV files
    a. Use #include <sycl/sycl.hpp> instead of #include <CL/sycl.hpp> to reduce deprecation warning
    b. Add missing instantiation for test for uint16_t
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Clean up of test_sycl_queue_submit_local_accessor_arg.cpp
b056d66 
1. Save test SPV filename into a variable
2. Add static assert that SIZE must be divisible by 10
3. Replaced hard-coded expected value with one that depends on SIZE
4. Fixed typos in the source code to generate SPV files
    a. Use #include <sycl/sycl.hpp>
    b. Add missing instantiation for uint16_t
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_516 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

ndgrigorian
ndgrigorian approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Coverage issue is related to an ongoing problem with coveralls, so I will just go ahead and merge

@ndgrigorian ndgrigorian merged commit ed02bea into master Feb 12, 2025
71 of 73 checks passed
@ndgrigorian ndgrigorian deleted the clean-up-test_sycl_queue_submit_local_accessor_arg.cpp branch February 12, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @ndgrigorian